[
https://issues.apache.org/jira/browse/YETUS-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428885#comment-15428885
]
Casey Brotherton commented on YETUS-442:
----------------------------------------
Looking through the code some more...Some notes for myself:
Notes for myself:
precommit/core.d/patchfiles.sh locate_patch
calls all of the ${bugsys}_locate_patch for each of the BUGSYSTEMS defined.
The loop in locate_patch in patchfiles.sh does not break when it finds a match.
When a bugsystem_locate_patch finds a match, the PATCH_SYSTEM env variable is
set.
when jira_locate_patch finds the github link, it calls the github_locate_patch,
and does
not set PATCH_SYSTEM.
The current code does not change that behaviour.
> JIRA plugin will not fallback to normal patch if it fails to find a github
> pull
> -------------------------------------------------------------------------------
>
> Key: YETUS-442
> URL: https://issues.apache.org/jira/browse/YETUS-442
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Affects Versions: 0.1.0, 0.2.0, 0.3.0, 0.2.1, 0.4.0
> Reporter: Casey Brotherton
> Assignee: Casey Brotherton
> Priority: Minor
> Attachments: YETUS-442.00.patch
>
>
> Initial determination of a github pull request uses a regular expression from
> the jira text
> If a JIRA appears to have a link to a github pull request,
> then the plugin will process the link further.
> If that processing fails, then the JIRA plugin will not attempt to fallback
> to
> checking for an attached patch file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
