[
https://issues.apache.org/jira/browse/YETUS-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429974#comment-15429974
]
Casey Brotherton commented on YETUS-443:
----------------------------------------
Downloaded 100 jira issues each from the following apache projects:
hadoop_yarn, hadoop_hdfs, kafka, and spark
to test the regular expression change.
Added a terminator to the regular expression in awk for:
" ( to handle xml export )
" to handle close of href= in message by the ASF GitHub Bot
space, as there is a space in another part of the message by the ASF Github Bot.
removed the "grep -c" in jira.sh to allow the function github_jira_bridge in
github.sh to be the only place for the regex.
> github pull request regular expression in the jira plugin should be more
> complete
> ---------------------------------------------------------------------------------
>
> Key: YETUS-443
> URL: https://issues.apache.org/jira/browse/YETUS-443
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Affects Versions: 0.4.0
> Reporter: Casey Brotherton
> Assignee: Casey Brotherton
> Priority: Minor
> Attachments: YETUS-443.00.patch
>
>
> The JIRA plugin ( jira.sh ) uses a regular expression to determine
> if there is a github pull request that contains a patch.
> There is a duplicate regular expression in github_jira_bridge in
> github.sh that is similar, as well as multiple regular expressions
> in github_locate_patch that look for slightly different patterns.
> The regular expression can wrongly determine that some links are
> github pull requests, as it looks for starting with GITHUB_BASE_URL
> and just that there are no spaces until the string "patch"
> This regular expression should be modified, as well as consideration to
> whether the regexes should be combined in some way.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
