[
https://issues.apache.org/jira/browse/YETUS-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kengo Seki updated YETUS-461:
-----------------------------
Attachment: YETUS-461.00.patch
Attaching a patch. Example:
{code}
sekikn@ubuntu:~/yetus$ cat /tmp/p
diff --git a/release-doc-maker/releasedocmaker.py
b/release-doc-maker/releasedocmaker.py
index 589a8c3..cf247e3 100755
--- a/release-doc-maker/releasedocmaker.py
+++ b/release-doc-maker/releasedocmaker.py
@@ -16,6 +16,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+# This line contains a tab here [ ] and a trailing whitespace.
+
from glob import glob
from optparse import OptionParser
from time import gmtime, strftime, sleep
sekikn@ubuntu:~/yetus$ precommit/test-patch.sh --build-tool=nobuild
--plugins=whitespace --branch=YETUS-461 --offline --resetrepo /tmp/p
(snip)
| Vote | Subsystem | Runtime | Comment
============================================================================
| -1 | whitespace | 0m 0s | The patch has 1 line(s) that end in
| | | | whitespace. Use git apply
| | | | --whitespace=fix <<patch_file>>. Refer
| | | | https://git-scm.com/docs/git-apply
| -1 | whitespace | 0m 0s | The patch 1 line(s) with tabs.
| | | 0m 1s |
(snip)
sekikn@ubuntu:~/yetus$ precommit/test-patch.sh --build-tool=nobuild
--plugins=whitespace --branch=YETUS-461 --offline --resetrepo
--whitespace-eol-ignore-list='.*release.*' /tmp/p
(snip)
| Vote | Subsystem | Runtime | Comment
============================================================================
| -1 | whitespace | 0m 0s | The patch 1 line(s) with tabs.
| | | 0m 0s |
(snip)
sekikn@ubuntu:~/yetus$ precommit/test-patch.sh --build-tool=nobuild
--plugins=whitespace --branch=YETUS-461 --offline --resetrepo
--whitespace-tabs-ignore-list='.*release.*' /tmp/p
(snip)
| Vote | Subsystem | Runtime | Comment
============================================================================
| -1 | whitespace | 0m 0s | The patch has 1 line(s) that end in
| | | | whitespace. Use git apply
| | | | --whitespace=fix <<patch_file>>. Refer
| | | | https://git-scm.com/docs/git-apply
| | | 0m 0s |
(snip)
sekikn@ubuntu:~/yetus$ precommit/test-patch.sh --build-tool=nobuild
--plugins=whitespace --branch=YETUS-461 --offline --resetrepo
--whitespace-eol-ignore-list='.*release.*'
--whitespace-tabs-ignore-list='.*release.*' /tmp/p
(snip)
| Vote | Subsystem | Runtime | Comment
============================================================================
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| | | 0m 1s |
{code}
> Allow specifying exclusions for whitespace report
> -------------------------------------------------
>
> Key: YETUS-461
> URL: https://issues.apache.org/jira/browse/YETUS-461
> Project: Yetus
> Issue Type: New Feature
> Components: build
> Reporter: stack
> Priority: Minor
> Attachments: YETUS-461.00.patch
>
>
> I have this in my report:
> {code}
> -1 whitespace 0m 0s The patch has 2298 line(s) that end in
> whitespace. Use git apply --whitespace=fix.
> {code}
> The 2298 lines are from files generated by protoc. I could try fixing protoc
> to not add the odd space at the end of a line but other tools than protoc
> probably have this tick.
> It would be sweet if I could configure the whitespace tooling passing a list
> of regexes to exclude when generating the report (Sean suggest it be a
> command-line config and told me file this issue). Thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
