Allen Wittenauer resolved YETUS-465.
    Resolution: Won't Fix

There's already a way to disable that. (don't use the 
--findbugs-strict-precheck flag)

The Hadoop community has opted to keep it a failure to draw attention to the 
fact that the findbugs issues tagged needs to get fixed and not forgotten.

Closing as won't fix.

> findbugs should not -1 if base branch has warnings when the patch fixes them
> ----------------------------------------------------------------------------
>                 Key: YETUS-465
>                 URL: https://issues.apache.org/jira/browse/YETUS-465
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Xiao Chen
> In HADOOP-13669, the base branch (trunk) has 2 findbugs warnings, and a patch 
> fixes them. But pre-commit returns:
> {noformat}
> -1    findbugs        0m 26s  hadoop-common-project/hadoop-kms in trunk has 2 
> extant Findbugs warnings.
> {noformat}
> IMO this would be better if it says +1 and (had 2 warnings, fixed).

This message was sent by Atlassian JIRA

Reply via email to