Casey Brotherton updated YETUS-464:
    Attachment: YETUS-464.001.patch

Attached are the changes I was thinking of so far.

Have not tested locally.  Will do so before I submit this as a patch.

Nothing for #2, to handle tildes, would need to use "eval"  or something 
similarly unusual.

Tilde's should be rare outside of a developer's workstation, so it probably 
isn't worth doing something unusual.

> test-patch silently continues when USER_PLUGIN_DIR doesn't exist
> ----------------------------------------------------------------
>                 Key: YETUS-464
>                 URL: https://issues.apache.org/jira/browse/YETUS-464
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.4.0
>            Reporter: Casey Brotherton
>            Assignee: Casey Brotherton
>            Priority: Minor
>         Attachments: YETUS-464.001.patch
> If one specifies a directory that does not exist in the --user-plugins 
> argument, test-patch.sh will quietly ignore the directory.
> This was found when using a tilde ( ~ ) to attempt home directory expansion 
> when testing a new plugin.
> Bash does not expand tilde's at the beginning of the line when quoted.
> Thoughts on resolving this:
>   1)  Should warn in the argument section in 01-common.sh if the directory 
> does not exist. ( Not only for USER_PLUGIN_DIR butt for any of the other 
> directories. )
>   2)  It might be possible to change yetus_abs to handle tilde expansion, and 
> then use that code to expand the parameter.  Of note is that yetus_abs is 
> used to expand USER_PLUGIN_DIR in test-patch.sh  
>   3)  If there are changes with the argument handling, it should be 
> considered to check with the arguments to ensure that they are not being 
> overwritten.  ( This would only happen with user error, but makes debugging 
> and understanding more difficult. )
> I will pull together a patch for #1, and reflect on #2/#3 further.  Any 
> comments, please add them to the Jira.

This message was sent by Atlassian JIRA

Reply via email to