[
https://issues.apache.org/jira/browse/YETUS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830409#comment-15830409
]
Ajay Yadava commented on YETUS-474:
-----------------------------------
Hi [~busbey],
It seems I owe to explain my suggestion. :)
I agree that the changes in {{releasedocmaker.py}} are definitely a good
improvement. I also agree that if a version exists and there are no issues
assigned to it, then we should get a proper error message. And my comments are
not on the {{releasedocmaker.py}} changes but on the changes in {{build.sh}}.
Even after the proposed changes of this patch in {{releasedocmaker.py}}, if
JIRA is unavailable or a version for which there are no issues assigned to it,
though we will get a better message, it will still not generate "release notes"
or "changelog". The current behavior of {{build.sh}} is to fail in such a case.
IMHO, this is useful in the common use case when one is trying to do a genuine
release.
So my only suggestion is to make the behavior of {{build.sh}} (whether to fail
if there are no changelog/release notes) configurable via a flag. Having a flag
like --fail-at-end for {{build.sh}} will definitely address this.
All this is based on the assumption, that the currently proposed changes in
{{build.sh}} will **always** ignore the lack of release notes/change log, no
matter what the underlying reason was.
> master build broken
> -------------------
>
> Key: YETUS-474
> URL: https://issues.apache.org/jira/browse/YETUS-474
> Project: Yetus
> Issue Type: Bug
> Components: build
> Affects Versions: 0.5.0
> Reporter: Sean Busbey
> Assignee: Suraj Acharya
> Priority: Blocker
> Fix For: 0.5.0
>
> Attachments: Bump_patch_to_0.99.98.patch,
> Bump_patch_to_0.99.99.patch, YETUS-474-01.patch, YETUS-474-02.patch,
> YETUS-474.patch
>
>
> {code}
> ./build.sh --release
> working on version '0.5.0-SNAPSHOT'
> generating release docs.
> There is no issue which has the specified version: 0.5.0
> mv: rename target/0.5.0/RELEASENOTES.0.5.0.md to target/RELEASENOTES.md: No
> such file or directory
> {code}
> I'm guessing it's the version bump and an edge case in handling RDM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
