[
https://issues.apache.org/jira/browse/YETUS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891760#comment-15891760
]
Yetus QA commented on YETUS-488:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 18m
47s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m
1s{color} | {color:red} The patch generated 1 new + 1 unchanged - 0 fixed = 2
total (was 1) {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
0s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
0s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 54s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/yetus:e4e4903 |
| JIRA Issue | YETUS-488 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12855566/YETUS-488.01.patch |
| Optional Tests | shellcheck shelldocs |
| uname | Linux 0e381748487f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / c08a3ee |
| shellcheck | v0.4.5 |
| shellcheck |
https://builds.apache.org/job/PreCommit-YETUS-Build/540/artifact/patchprocess/diff-patch-shellcheck.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-YETUS-Build/540/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Checkstyle reports new error if the file still longer than expected
> -------------------------------------------------------------------
>
> Key: YETUS-488
> URL: https://issues.apache.org/jira/browse/YETUS-488
> Project: Yetus
> Issue Type: Improvement
> Components: Test Patch
> Affects Versions: 0.4.0
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Minor
> Attachments: YETUS-488.00.patch, YETUS-488.01.patch
>
>
> Given a java source file which is originally longer than the checkstyle
> defined value then we get the following warning every time the length changes
> and we run the checkstyle plugin:
> {code}
> ./beeline/src/java/org/apache/hive/beeline/BeeLine.java:1: warning: File
> length is 2,373 lines (max allowed is 2,000).
> {code}
> The problem is, that the checkstyle output is changed:
> {code:title=From}
> ./beeline/src/java/org/apache/hive/beeline/BeeLine.java:1: warning: File
> length is 2,373 lines (max allowed is 2,000).
> {code}
> {code:title=To}
> ./beeline/src/java/org/apache/hive/beeline/BeeLine.java:1: warning: File
> length is 2,365 lines (max allowed is 2,000).
> {code}
> Since the {{checkstyle_calcdiffs}} does not find the new line in the original
> output, it marks it as a new error, and gives -1 to the result of the
> checkstyle plugin.
> This is true for every error message where there is a number in the text. Not
> exhaustive examples are below:
> - Line length
> - Row length
> - Function length
> - Number of attributes
> - Indentation
> I think we should be reluctant to give -1 without a reason so it would be
> good to remove these errors.
> I have yet to find the ideal solution for the issue:
> - An easy patch could be to remove the numbers from files before the diff
> (note: it does not effect the final diff-checkstyle-<MODULE>.txt output
> messages). This would mean that the warning will give -1 only the first time
> when the error text is occurred, and will not give -1 if the numbers are
> changed, like
> -- File become shorter, but still longer than expected
> -- File become even longer
> -- Indentation changed but still problematic
> - A more sophisticated patch could do this only for specific errors, or even
> check the value and give error when the line length grow.
> To be honest, I think the second solution would complicate the code too much,
> and make it dependent on the specific checkstyle messages, so I do not like
> it.
> I am even hesitant about the first one, because the change I introducing with
> it might have unwanted consequences.
> Do anyone has better ideas? I would be happy to implement them, if someone
> points me to the right direction :D
> Thanks,
> Peter
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
