[ 
https://issues.apache.org/jira/browse/YETUS-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012639#comment-16012639
 ] 

Sean Busbey commented on YETUS-507:
-----------------------------------

So essentially we'd need an option to skip reporters if the bug system said "I 
don't see something ready for review". Does that sound correct?

Would this only be for cases where the bug system (passing e.g. YETUS-507 as 
the thing to consider) said "nothing that looks like a patch" or would it be 
acceptable to generalize for cases of smart-apply-patch can't figure out what a 
file is?

The reason I ask is that I think right now the logic for "bug system turn this 
ID into an attachment" and "is attachment a patch" are two different parts of 
the code base that don't know about each other.

> Add option to suppress output if patch detection fails
> ------------------------------------------------------
>
>                 Key: YETUS-507
>                 URL: https://issues.apache.org/jira/browse/YETUS-507
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Mike Drob
>
> I'd like to be able to use Yetus with a JIRA workflow that doesn't have a 
> Patch Available state. This means that I'll be looking at all attachment 
> updates as they come in, some of which will be patches, but others will be 
> screenshots, logs, etc.
> Instead of downloading the latest attachment, figuring out what it is, and 
> then potentially triggering Yetus, I'd like to be able to delegate that to 
> Yetus since I think it already has that logic (and would be doing patch 
> detection anyway). Then, when an attachment fails patch detection, I'd like 
> Yetus to fail silently instead of updating the JIRA with a -1 precommit 
> check. There's no reason to post an update when somebody gives me a 
> screenshot, and the -1 would likely confuse people more than it would help on 
> the true patch apply failures.
> This should be a configurable option that is off by default.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to