[
https://issues.apache.org/jira/browse/YETUS-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017985#comment-16017985
]
Allen Wittenauer commented on YETUS-315:
----------------------------------------
bq. Currently setting an environment variable GPGSIGN=true will make it similar
to the --gpg-sign flag.
This feels too generic. If we're going to use an *external* env var, then I'd
prefer 'YETUS_GPGSIGN'. (We should really do this for all of them...) Or is
the idea that the personality would be the place to set this? (That seems
aggressive to me.)
bq. If someone doesnt have the keys setup then there is a gpg error.
I think that's ok for a first pass. We can always iterate on it.
Also: I'm not too worried about the "oops I signed with the wrong id" problem.
Users can always 'rebase -i' it away before pushing the tree.
> smart-apply-patch committer mode should support signed commits
> --------------------------------------------------------------
>
> Key: YETUS-315
> URL: https://issues.apache.org/jira/browse/YETUS-315
> Project: Yetus
> Issue Type: New Feature
> Components: Test Patch
> Reporter: Allen Wittenauer
> Assignee: Suraj Acharya
> Fix For: 0.5.0
>
>
> A new {{--gpg-sign}} flag is added to the smart-apply-patch.sh.
> This will allow the committer to sign the commit.
> GPG Agent will handle the passphrase request.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
