[
https://issues.apache.org/jira/browse/YETUS-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022323#comment-16022323
]
Kengo Seki commented on YETUS-483:
----------------------------------
Tested with a sample patch and looks good, except for the following nits:
{code}
272 ## @description Add the `appendstring` if `checkstring` is not
273 ## @description present in the given array
274 ## @audience public
275 ## @stability stable
276 ## @replaceable yes
277 ## @param envvar
278 ## @param appendstring
279 function yetus_add_array_element
{code}
* `checkstring` -> it?
* envvar -> array?
{code}
296 ## @description Sort an array (must not contain regexps)
297 ## @description present in the given array
298 ## @audience public
299 ## @stability stable
300 ## @replaceable yes
301 ## @param arrayvar
302 function yetus_sort_array
{code}
* Line 297 seems unnecessary.
> shellcheck plugin should be smarter about its queue
> ---------------------------------------------------
>
> Key: YETUS-483
> URL: https://issues.apache.org/jira/browse/YETUS-483
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Affects Versions: 0.4.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Fix For: 0.5.0
>
> Attachments: YETUS-483.00.patch, YETUS-483.01.patch
>
>
> The shellcheck plugin should probably detect common types and not add them to
> it's queue when adding files from bin/*. e.g.,
> dev-support/bin/checkcompatibility.py in the Apache Hadoop tree.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
