[
https://issues.apache.org/jira/browse/YETUS-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070759#comment-16070759
]
Sean Busbey commented on YETUS-527:
-----------------------------------
the test4tests module checks that the build system has already determined unit
tests are needed
([ref|https://github.com/apache/yetus/blob/612a0f2/precommit/test-patch.d/test4tests.sh#L36]):
{code}
if ! verify_needed_test unit; then
echo "Patch does not appear to need new or modified tests."
return 0
fi
{code}
I was mistaken earlier, the checks for "touches docs" I was thinking for are
additive, looking to see if the "maven site" goal is needed. (if interested
those checks are here: [general maven
behavior|https://github.com/apache/yetus/blob/362d621/precommit/test-patch.d/maven.sh#L210],
[hadoop's
customization|https://github.com/apache/yetus/blob/2971eff54d659538f1076b766250385418b6585f/precommit/personality/hadoop.sh#L355],
[hbase's
customization|https://github.com/apache/yetus/blob/2971eff54d659538f1076b766250385418b6585f/precommit/personality/hbase.sh#L303]).
So this must be a bug where we think unit tests are needed when they aren't.
Can we get an example run with {{--debug}} present?
> recognize docs patches
> ----------------------
>
> Key: YETUS-527
> URL: https://issues.apache.org/jira/browse/YETUS-527
> Project: Yetus
> Issue Type: Improvement
> Components: Test Patch
> Reporter: Mike Drob
>
> When somebody posts a doc-only patch, we shouldn't make a red -1 on
> test4tests over it.
> Maybe detect if all the changed files are {{.adoc}} or {{.md}} or maybe
> there's some other type to consider also.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
