[
https://issues.apache.org/jira/browse/YETUS-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234430#comment-16234430
]
Yetus QA commented on YETUS-568:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} pylint {color} | {color:green} 0m
5s{color} | {color:green} There were no new pylint issues. {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
5s{color} | {color:red} The patch generated 1 new + 5 unchanged - 1 fixed = 6
total (was 6) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
1s{color} | {color:red} The patch generated 1 new + 29 unchanged - 1 fixed = 30
total (was 30) {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
0s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
0s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/yetus:53f22ae |
| JIRA Issue | YETUS-568 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12895238/YETUS-568.01.patch |
| Optional Tests | rubocop ruby_lint shellcheck shelldocs pylint |
| uname | Linux a2f7ff0ea84c 3.19.0-25-generic #26~14.04.1-Ubuntu SMP Fri Jul
24 21:16:20 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 834d7a4 |
| shellcheck | v0.4.6 |
| pylint | v1.7.4 |
| rubocop | v0.51.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-YETUS-Build/665/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-YETUS-Build/665/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-YETUS-Build/665/console |
| Powered by | Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> break apart versioning of files and directories
> -----------------------------------------------
>
> Key: YETUS-568
> URL: https://issues.apache.org/jira/browse/YETUS-568
> Project: Yetus
> Issue Type: Improvement
> Components: Release Doc Maker
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Major
> Attachments: YETUS-568.00.patch, YETUS-568.01.patch
>
>
> Currently, releasedocmaker always generates a version directory wherever it
> is told to write it's output:
> {code}
> rdm -p yetus -v 0.6.0 -> 0.6.0/CHANGES.0.6.0.md
> 0.6.0/RELEASENOTES.0.6.0.md
> rdm -o foo -p yetus -v 0.6.0 -> foo/0.6.0/CHANGES.0.6.0.md
>
> foo/0.6.0/RELEASENOTES.0.6.0.md
> {code}
>
> In some situations, this is really less than ideal, especially given that the
> files also have the version stuck in them. (In fact, the current rdm output
> is making life difficult for Yetus' own release process.)
> We need to rethink this a bit. Some ideas for improvement:
> * Add a flag (--fileversions?) that add the version to the filenames, e.g.,
> CHANGES.MD to CHANGES.0.6.0.md
> * Add a flag (--dirversions?) that creates the version directory. e..g., -O
> foo --dirversions would write in foo/0.6.0 as it does today.
> While we are breaking rdm, it may be worthwhile to change from CHANGES to
> CHANGELOG, which will make a lot of other software that looks specifically
> for CHANGELOG files happy.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
