[ 
https://issues.apache.org/jira/browse/YETUS-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276285#comment-16276285
 ] 

Akira Ajisaka commented on YETUS-586:
-------------------------------------

bq. I'd rather we use long-form arguments
I'll use {{--all}} in the next patch.

bq. Could you confirm that our minimum stated git version doesn't have this old 
behavior?

* Yetus now requires Git 1.7.3 or higher. 
https://github.com/apache/yetus/blob/1dcbbeb3f3ecac50f08272daba8aa196dd023227/precommit/core.d/01-common.sh#L196
* The new behavior was introduced in Git 2.0.0. 
https://github.com/git/git/blob/master/Documentation/RelNotes/2.0.0.txt#L25

Therefore our minimum stated git version has this old behavior.

> smart-apply-patch --committer misses new directories
> ----------------------------------------------------
>
>                 Key: YETUS-586
>                 URL: https://issues.apache.org/jira/browse/YETUS-586
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.7.0
>            Reporter: Allen Wittenauer
>            Assignee: Akira Ajisaka
>            Priority: Critical
>         Attachments: YETUS-586.000.patch
>
>
> if smart-apply-patch is given a patch that is in raw patch format (e.g., 
> HDFS-11096 #7), it will not add the new directories when run with --committer 
> mode.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to