[
https://issues.apache.org/jira/browse/YETUS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465997#comment-16465997
]
Elek, Marton commented on YETUS-631:
------------------------------------
Thanks a lot for your comments/suggestions.
1. Personality: I think adding this to the maven.sh instead of adding to the
personality gives more flexibility to us. Some use-cases: I would like to check
the same patches with and without a specific maven profile (for example to
check if both hdds and standard hdfs builds are working well, or to check it
works with multiple hadoop version). Also YETUS-558 (turning on maven verbose
log) could be handled in this level. But if you have suggestions how can I
implement it on personality level, I am happy to work on it.
2. Yes, currently it supports only one parameter. I [tried to fix
it|https://github.com/elek/yetus/commit/e513a6779c5935aa920ff2c46c35a3ecd94346f6],
but unfortunately it can't work with docker. (It works well with non-docker
runs). It seems that when yetus is passing the original arguments to the docker
environment the quotes are removed. Still debuging it. Is it acceptable to use
the same --maven-args multiple times? Maybe that would be the easiest fix...
3._ "Given that mvn exec:exec is still seeing the modules that are allegedly
protected by the profile"_: I thought (fix me if I am wrong) mvn exec:exec will
see the hdds/ozone projects only if -Phdds is turned on. For me, it's seems to
be working. I did some example run with PreCommit-HDDS-Build. Let me know
what's wrong and I will check it.
> Add new command line parameter to define custom mvn argument
> ------------------------------------------------------------
>
> Key: YETUS-631
> URL: https://issues.apache.org/jira/browse/YETUS-631
> Project: Yetus
> Issue Type: Improvement
> Components: Test Patch
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Attachments: YETUS-631.001.patch
>
>
> The HDDS subproject is turned off by default in Hadoop source tree. To make a
> workable Precommit-HDDS-Build we need a possibility to defined additional mvn
> arguments from the command line.
> (I tried to use .mvn/maven.config but the current build forces a git clean
> build. Environment variable could not been used in dockerized environment )
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
