[
https://issues.apache.org/jira/browse/YETUS-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581307#comment-16581307
]
Allen Wittenauer commented on YETUS-659:
----------------------------------------
After playing with this a bit,
a) checkstyle in HDFS for Hadoop doesn't work because someone munged the
suppressions file:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:checkstyle (default-cli)
on project hadoop-hdfs: An error has occurred in Checkstyle report generation.
Failed during checkstyle execution: Failed to load suppressions file from:
/testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/checkstyle-suppressions.xml:
Unable to parse
/testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/checkstyle-suppressions.xml
- invalid files or checks or message format: Dangling meta character '*' near
index 0
{code}
b) Yetus should be reporting that checkstyle failed to work rather than blankly
saying it passed due to no differences.
> Checkstyle shows false positive report
> --------------------------------------
>
> Key: YETUS-659
> URL: https://issues.apache.org/jira/browse/YETUS-659
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Reporter: Kitti Nanasi
> Priority: Minor
>
> If a patch is created with checkstyle errors, for example when a modified
> line is longer than 80 characters, then running checkstyle with the
> test-patch script runs to success (though it should fail and show an error
> about the long line).
> {code:java}
> dev-support/bin/test-patch --plugins="-checkstyle" test.patch{code}
> However it does show the error (so works correctly) when running it with the
> IDEA checkstyle plugin.
>
> I only tried it out it for patches with too long lines and wrong indentation,
> but I assume that it can be a more general problem.
> We realised this when reviewing HDFS-13217, where patch 004 has a "too long
> line" checkstyle error. In the first build for that patch, the checkstyle
> report was showing the error, but when it was ran again with the same patch,
> the error disappeared. So probably the checkstyle checking stopped working on
> trunk somewhere between April and July 2018.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
