[
https://issues.apache.org/jira/browse/YETUS-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582603#comment-16582603
]
Allen Wittenauer commented on YETUS-658:
----------------------------------------
This is looking great. Beyond the shellcheck errors:
minor nit:
{code}
'+ if [[ ! -z "${maven_unit_test_filter}" ]]; then
{code}
should be -n.
Some error handling in test-patch.sh would be great:
* UNIT_TEST_FILTER_FILE should be checked to exist. If not, test-patch should
probably exit with a failure.
* UNIT_TEST_FILTER_FILE should get converted via yetus_abs in parse args. This
way if a relative path is given, it will still work.
The other thing is that this file needs special handling for docker.
In copytpbits in test-patch.sh, if the UNIT_TEST_FILTER_FILE exists, the file
needs to get copied to the precommit dir with a known file name. Then in
launch-test-patch.sh, if that file name exists, override the
\-\-unit-test-filter-file option like it does the console report file option.
> Built-in Support For Unit Test Excluding
> ----------------------------------------
>
> Key: YETUS-658
> URL: https://issues.apache.org/jira/browse/YETUS-658
> Project: Yetus
> Issue Type: Improvement
> Reporter: Jack Bearden
> Assignee: Jack Bearden
> Priority: Critical
> Attachments: YETUS-658.001.patch, YETUS-658.002.patch
>
>
> Been using Yetus for a month and I must say, it's a great product for our
> Hadoop unit testing pipelines. However, I would like it to have native
> support for excluding junit tests. Some of the test results just don't have
> value to us and would like to ignore them.
> I have a patch that adds an argument to testpatch with a path to an exclude
> file. This file is then parsed into the unit test command in Maven.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
