[ 
https://issues.apache.org/jira/browse/YETUS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589308#comment-16589308
 ] 

Jack Bearden commented on YETUS-660:
------------------------------------

This was a really weird incident. Great catch man. I pulled in patch 01, added 
a checkstyle line I got from the hadoop ticket in the description, and ran 
testpatch with a dummy patch. I now see a "trunk compilation: pre-patch" maven 
install before checkstyle and get the following:


{code:java}
Failed to load suppressions file from: 
/private/tmp/yetus.hadoop/srcdir/hadoop-build-tools/target/checkstyle-suppressions.xml:
 Unable to parse 
/private/tmp/yetus.hadoop/srcdir/hadoop-build-tools/target/checkstyle-suppressions.xml
 - invalid files or checks or message format: Dangling meta character '*' near 
index 0{code}

Looks like it is working to me. When I tried on yetus master, checkstyle passed 
and missed this entirely. +1 

> checkstyle should report when it fails to execute
> -------------------------------------------------
>
>                 Key: YETUS-660
>                 URL: https://issues.apache.org/jira/browse/YETUS-660
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.8.0
>
>         Attachments: YETUS-660.00.patch, YETUS-660.01.patch
>
>
> As shown in HDDS-119/HADOOP-15675, the checkstyle plug-in fails to determine 
> if it didn't actually run. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to