[
https://issues.apache.org/jira/browse/YETUS-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684471#comment-16684471
]
Allen Wittenauer edited comment on YETUS-713 at 11/12/18 11:24 PM:
-------------------------------------------------------------------
There are lots of problems with the pylint driver, but the chief one is that
--pylint-options doesn't really work with all file systems. In order to work
around the shellcheck error, it looks like this was placed into an eval. Doing
this in an eval makes the command harder to maintain in addition to hiding
shellcheck problems.
It has been a while since we visited pylint, so probably time to just rewrite
it to make it work as expected. As part of this, I'm opting to deprecate the
--pylint-options command and instead take advantage of the pylint rcfile to
store options. This gets us away from trying to parse a string into an array.
Also, briefreport makes assumptions about logs that pylint openly breaks. So
let's fix briefreport to be a bit more resilient and make it pass shellcheck
while we are there.
was (Author: aw):
There are lots of problems with the pylint driver, but the chief one is that
--pylint-options doesn't really work with all file systems. In order to work
around the shellcheck error, it looks like this was placed into an eval. Doing
this in an eval makes the command harder to maintain in addition to hiding
shellcheck problems.
It has been a while since we visited pylint, so probably time to just rewrite
it to make it work as expected. As part of this, I'm opting to deprecate the
--pylint-options command and instead take advantage of the pylint rcfile to
store options. This gets us away from trying to parse a string into an array.
Also, briefreport makes assumptions about logs that pylint openly breaks. So
let's fix briefreport to be a bit more resilient.
> pylint: rewrite to make it easier to maintain and fix stderr output in brief
> report
> -----------------------------------------------------------------------------------
>
> Key: YETUS-713
> URL: https://issues.apache.org/jira/browse/YETUS-713
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Affects Versions: 0.8.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Major
> Fix For: 0.9.0
>
> Attachments: YETUS-713.000.patch
>
>
> persistent mode and scoring should be turned off and the stderr output builds
> a table that briefreport can't read.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
