[ 
https://issues.apache.org/jira/browse/YETUS-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706449#comment-16706449
 ] 

Allen Wittenauer edited comment on YETUS-723 at 12/2/18 7:48 PM:
-----------------------------------------------------------------

-02:
* Renamed some options from '\-\-dockerFOO' to '\-\-docker-FOO' to be more 
consistent with the rest of the precommit (\-\-docker-platform, \-\-docker-tag, 
\-\-docker-socket)
* Moved some configuration overrides out of the launcher and into USER_PARAMS 
so that they are less hidden
* wired up \-\-docker-socket to actually work
* added \-\-docker-bash-debug to run test-patch in 'bash -x' mode. This fixes 
YETUS-185.
* added docker, docker-compose, and dependencies to the Dockerfile so that 
Docker-in-Docker mode actually works out of the box
* As a result, Docker privileged mode is now off by default.
* Reworked the ANT_ARGS to be YETUS_ANT_ARGS so that we specifically don't 
overwrite what the user may have defined in the shell.



was (Author: aw):
-02:
* Renamed some options from '\-\-dockerFOO' to '\-\-docker-FOO' to be more 
consistent with the rest of the precommit (\-\-docker-platform, \-\-docker-tag, 
\-\-docker-socket)
* Moved some configuration overrides out of the launcher and into 
USER_PARAMETERS so that they are less hidden
* wired up \-\-docker-socket to actually work
* added \-\-docker-bash-debug to run test-patch in 'bash -x' mode. This fixes 
YETUS-185.
* added docker, docker-compose, and dependencies to the Dockerfile so that 
Docker-in-Docker mode actually works out of the box
* As a result, Docker privileged mode is now off by default.
* Reworked the ANT_ARGS to be YETUS_ANT_ARGS so that we specifically don't 
overwrite what the user may have defined in the shell.


> Overhaul the docker support for 2018
> ------------------------------------
>
>                 Key: YETUS-723
>                 URL: https://issues.apache.org/jira/browse/YETUS-723
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.9.0
>
>         Attachments: YETUS-723.02.patch, YETUS-723.aw-repo-00.patch, 
> YETUS-723.aw-repo-01.patch
>
>
> Many core parts of the Docker support haven't been touched in 3 years.  Since 
> that time, we have learned many things about how people use Docker with 
> test-patch and Docker itself has added many new features.  It's time to 
> overhaul the basic plug-in to take advantage of everything we've learned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to