[ 
https://issues.apache.org/jira/browse/YETUS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787210#comment-16787210
 ] 

Allen Wittenauer commented on YETUS-724:
----------------------------------------

Patch breaks smart-apply-patch, at least the reporting function.

> github diff vs. patch
> ---------------------
>
>                 Key: YETUS-724
>                 URL: https://issues.apache.org/jira/browse/YETUS-724
>             Project: Yetus
>          Issue Type: New Feature
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.10.0
>
>         Attachments: YETUS-724.00.patch
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Experience has shown that patch is more accurate diff.  However, we could 
> still try diff.  Doing so would enable a lot more scenarios where unsquashed 
> commits would work. Warn that reported line numbers and binary files may not 
> be accurate as a result rather than just flat out failing... with the premise 
> that some output is better than none.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to