[
https://issues.apache.org/jira/browse/YETUS-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated YETUS-724:
-----------------------------------
Release Note:
<!-- markdown -->
precommit will now attempt to try both forms of git patches (binary
format-patch and ASCII git diff) when working with Github PRs or Gitlab MRs. It
will prefer the format-patch style due to accuracy, but will fallback to diff
style if the former does not apply successfully.
> github diff vs. patch
> ---------------------
>
> Key: YETUS-724
> URL: https://issues.apache.org/jira/browse/YETUS-724
> Project: Yetus
> Issue Type: New Feature
> Components: Precommit
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Major
> Fix For: 0.10.0
>
> Attachments: YETUS-724.00.patch, YETUS-724.01.patch,
> YETUS-724.02.patch
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Experience has shown that patch is more accurate diff. However, we could
> still try diff. Doing so would enable a lot more scenarios where unsquashed
> commits would work. Warn that reported line numbers and binary files may not
> be accurate as a result rather than just flat out failing... with the premise
> that some output is better than none.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
