[
https://issues.apache.org/jira/browse/YETUS-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038179#comment-17038179
]
Pierre Smits commented on YETUS-936:
------------------------------------
What I experienced in my OFBiz clone, after Yetus finished, was:
{code:java}
============================================================================
============================================================================
Applying patch to ofbiz-pr12
============================================================================
============================================================================
Applying the changes:
Mon Feb 17 08:51:03 UTC 2020
cd /Users/nl04748/dev/asf/ofbiz/ofbiz-framework
git apply --binary -v --stat --apply -p1
/Users/nl04748/dev/test/yetus/input.patch
/Users/nl04748/dev/test/yetus/input.patch:75: trailing whitespace.
/Users/nl04748/dev/test/yetus/input.patch:323: trailing whitespace.
/Users/nl04748/dev/test/yetus/input.patch:324: trailing whitespace.
<menu name="ShipmentTabBar" title=" " extends="CommonTabBarMenu"
/Users/nl04748/dev/test/yetus/input.patch:326: trailing whitespace.
Applied patch applications/datamodel/entitydef/shipment-entitymodel.xml cleanly.
Applied patch applications/product/config/ProductUiLabels.xml cleanly.
Applied patch applications/product/servicedef/services_shipment.xml cleanly.
Applied patch applications/product/template/shipment/ShipmentTabBar.ftl cleanly.
Applied patch applications/product/webapp/facility/WEB-INF/controller.xml
cleanly.
Applied patch applications/product/widget/facility/ShipmentForms.xml cleanly.
Applied patch applications/product/widget/facility/ShipmentMenus.xml cleanly.
Applied patch applications/product/widget/facility/ShipmentScreens.xml cleanly.
warning: 4 lines add whitespace errors.
.../datamodel/entitydef/shipment-entitymodel.xml | 35 ++++-
applications/product/config/ProductUiLabels.xml | 22 +++
.../product/servicedef/services_shipment.xml | 18 ++
.../product/template/shipment/ShipmentTabBar.ftl | 49 ------
.../product/webapp/facility/WEB-INF/controller.xml | 13 ++
.../product/widget/facility/ShipmentForms.xml | 30 ++++
.../product/widget/facility/ShipmentMenus.xml | 152 ++++++++++++++++++++
.../product/widget/facility/ShipmentScreens.xml | 72 +++------
8 files changed, 289 insertions(+), 102 deletions(-)
============================================================================
============================================================================
Checking for whitespace issues.
============================================================================
============================================================================
============================================================================
============================================================================
XML verification: patch
============================================================================
============================================================================
============================================================================
============================================================================
Determining number of ASF License errors
============================================================================
============================================================================
cd /Users/nl04748/dev/asf/ofbiz/ofbiz-framework
/Users/nl04748/dev/asf/ofbiz/ofbiz-framework/gradlew rat >
/Users/nl04748/dev/test/yetus/patch-asflicense-root.txt 2>&1
Elapsed: 0m 45s
cd /Users/nl04748/dev/asf/ofbiz/ofbiz-framework
/Users/nl04748/dev/asf/ofbiz/ofbiz-framework/gradlew --stop >
/Users/nl04748/dev/test/yetus/gradle-postcleanup-log.txt 2>&1
Total Elapsed time: 11m 11s
============================================================================
============================================================================
Adding comment to Gitlab
============================================================================
============================================================================
Gitlab Plugin: no credentials provided to write a comment.
-1 overall
_____ _ _ _
| ___|_ _(_) |_ _ _ __ ___| |
| |_ / _` | | | | | | '__/ _ \ |
| _| (_| | | | |_| | | | __/_|
|_| \__,_|_|_|\__,_|_| \___(_)
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 32s | Docker mode activated.
+---------------------------------------------------------------------------
| | | | Prechecks
+---------------------------------------------------------------------------
| +1 | dupname | 0m 1s | No case conflicting files found.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
+---------------------------------------------------------------------------
| | | | ofbiz-pr12 Compile Tests
+---------------------------------------------------------------------------
+---------------------------------------------------------------------------
| | | | Patch Compile Tests
+---------------------------------------------------------------------------
| -1 | whitespace | 0m 0s | The patch has 4 line(s) that end in
| | | | whitespace. Use git apply
| | | | --whitespace=fix <<patch_file>>. Refer
| | | | https://git-scm.com/docs/git-apply
| +1 | xml | 0m 24s | The patch has no ill-formed XML file.
+---------------------------------------------------------------------------
| | | | Other Tests
+---------------------------------------------------------------------------
| 0 | asflicense | 0m 58s | ASF License check generated no output?
| | | 11m 11s |
|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=18.09.2 Server=18.09.2 base:
/Users/nl04748/dev/test/yetus/Dockerfile |
| GITHUB PR | https://github.com/apache/ofbiz-framework/pull/12 |
| Optional Tests | dupname asflicense xml |
| uname | Linux c01131fc84ac 4.9.125-linuxkit #1 SMP Fri Sep 7 08:20:28 UTC
2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | gradle |
| git revision | ofbiz-pr12 / 969f48b |
| whitespace | /Users/nl04748/dev/test/yetus/whitespace-eol.txt |
| Max. process+thread count | 59 (vs. ulimit of 1000) |
| modules | C: . U: . |
| versions | git=2.7.4 gradle=5.0 |
| Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org |
Cleaning up docker image used for testing.
============================================================================
============================================================================
Finished build.
============================================================================
============================================================================
{code}
Somehow the 'ShipmentMenus.xml' got changed and git starts to complain when I
try to stash the uncommitted changes. When I checked my Git client, I don't see
that 'ShipmentMenus.xml' file appearing. I suspect that this is the result of
the whitespace check.
The result I got was:
{code:java}
error: Entry 'applications/product/widget/facility/ShipmentMenus.xml' not
uptodate. Cannot merge.
Cannot save the current worktree state
{code}
> test-patch.sh does not do gradle
> --------------------------------
>
> Key: YETUS-936
> URL: https://issues.apache.org/jira/browse/YETUS-936
> Project: Yetus
> Issue Type: Bug
> Components: build
> Affects Versions: 0.11.1
> Environment: MacBook, with in $HOME the .gradle folder. The
> wrapper/thereunder folder thereunder contains: gradle-2.13-bin,
> gradle-3.2.1-bin, gradle-5.0-bin, gradle-5.6.2-all
> Reporter: Pierre Smits
> Assignee: Allen Wittenauer
> Priority: Blocker
> Labels: docker, gradle
> Time Spent: 50m
> Remaining Estimate: 0h
>
> While trying to do a 'test-patch' on a PR in the ofbiz-framework repo on
> Github with following command
> {code:java}
> ~/dev/asf/yetus/precommit/src/main/shell/test-patch.sh
> --basedir=/Users/nl04748/dev/asf/ofbiz/ofbiz-framework --build-tool=gradle
> --dirty-workspace --docker --patch-dir=/Users/nl04748/dev/test/yetus
> --plugins=all --project=ofbiz
> https://github.com/apache/ofbiz-framework/pull/12
> {code}
> I get following error returned:
> {code:java}
> ERROR: gradle is not available.
> {code}
> See also linked mail thread
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
