Nick Dimiduk created YETUS-951:
----------------------------------

             Summary: test-patch should complain more loudly about unrecognized 
PATCH_OR_ISSUE
                 Key: YETUS-951
                 URL: https://issues.apache.org/jira/browse/YETUS-951
             Project: Yetus
          Issue Type: Improvement
          Components: Precommit
            Reporter: Nick Dimiduk


I ended up losing a fair bit of time the other day, trying to work on a GitHub 
PR pre-check without enabling the {{github}} plugin. The error messages apply 
patch were obscure and unhelpful. I think the fall-through logic should be more 
helpful, printing a message that says something like "Unrecognized patch 
reference / don't know what to do with ${PATCH_OR_ISSUE}." The current 
messaging just says "ERROR: ${PATCH_OR_ISSUE} does not apply to 
${PATCH_OR_ISSUE}," which left me thinking somehow the git checkout wasn't 
clean, when in fact there was no plugin support for the GitHub PR URL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to