[
https://issues.apache.org/jira/browse/YETUS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052243#comment-17052243
]
Sean Busbey commented on YETUS-918:
-----------------------------------
If the project has PRs that don't have independent github issues that won't be
true. at least when I am grabbing PRs it won't include the PR that closes
unless the contributor did it manually in their commit message.
if I do any of the merge options through the githb UI then the commit message
it generates by default will include the "closes #FOO" reference to the PR.
It'd be nice to enable that same convenience for folks who have a workflow that
includes local application + testing via smart-apply-patch with a push directly
(rather than say going back to the github UI to do the merge action)
> smart-apply-patch should include a "closes #foo" when apply github PRs in
> committer mode
> ----------------------------------------------------------------------------------------
>
> Key: YETUS-918
> URL: https://issues.apache.org/jira/browse/YETUS-918
> Project: Yetus
> Issue Type: Improvement
> Components: Precommit
> Reporter: Sean Busbey
> Priority: Minor
>
> It would be nice if {{smart-apply-patch}} included one of the keyword phrases
> in the commit message to close out the referenced pr when processing a github
> contribution in committer mode.
>
> [https://help.github.com/en/articles/closing-issues-using-keywords]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
