[
https://issues.apache.org/jira/browse/YETUS-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201155#comment-17201155
]
Allen Wittenauer edited comment on YETUS-1000 at 9/23/20, 10:58 PM:
--------------------------------------------------------------------
GitHub Actions can implement this feature trivially. For non-GHA, it is a bit
more complicated, but possible based on a bit of playing I've done. A few
gotchas:
* Most systems are NOT sharing a token and/or the check run id, if they even
have one. test-patch will need to allocate its own.
* The checks ID should probably be grabbed as soon as possible. In order to do
this, I'm going to expand _precheck into bugsystems.
* The checks ID also needs to be closed. I'm add a new API that can be called
during cleanup_and_exit for bugsystems.
* linecomments, as of 0.12.0, are completely busted. It's a trivial fix,
luckily.
was (Author: aw):
I've done a bit of playing around with this feature. There a few gotchas:
* Most systems are NOT sharing a token and/or the check run id, if they even
have one. test-patch will need to allocate its own.
* The checks ID should probably be grabbed as soon as possible. In order to do
this, I'm going to expand _precheck into bugsystems.
* The checks ID also needs to be closed. I'm add a new API that can be called
during cleanup_and_exit for bugsystems.
* linecomments, as of 0.12.0, are completely busted. It's a trivial fix,
luckily.
> Switch out GitHub line-level comments to GitHub Checks Annotations
> ------------------------------------------------------------------
>
> Key: YETUS-1000
> URL: https://issues.apache.org/jira/browse/YETUS-1000
> Project: Yetus
> Issue Type: New Feature
> Components: Precommit
> Affects Versions: 0.13.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Major
>
> Replace the github line comments with checks annotations. Doing so will make
> the lack of logging less painful in addition to bringing non-GitHub Actions
> setups more consistent.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
