[
https://issues.apache.org/jira/browse/YETUS-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202881#comment-17202881
]
Allen Wittenauer edited comment on YETUS-966 at 9/27/20, 5:25 PM:
------------------------------------------------------------------
It looks like we can make this code flow a tad smarter:
* For github actions take out the robot-level repo manipulation. We just need
to require v2 and fetch-depth of 0. That gets us a full history.
* change the pull to be 'git pull --rebase --tags --force'
These parameters will also force the pull to forcibly update and override tags.
Since this is in resetrepo mode, the expectation that the repo is going to get
changed should already be there, making this (potentially destructive) change
ok. Since the tags were forcibly changed, later on test-patch now:
* looks to see if the PATCH_BRANCH exists in the .git/refs/tags directory. If
so, then it is a tag.
* only do the git fetch + git reset in the case of non-tag
I believe that will fix it while also not-breaking everything else.
was (Author: aw):
It looks like we can make this code flow a tad smarter:
* change the pull to be 'git pull --rebase --tags --force'
These parameters will also force the pull to forcibly update and override tags.
Since this is in resetrepo mode, the expectation that the repo is going to get
changed should already be there, making this (potentially destructive) change
ok. Since the tags were forcibly changed, later on test-patch now:
* looks to see if the PATCH_BRANCH exists in the .git/refs/tags directory. If
so, then it is a tag.
* only do the git fetch + git reset in the case of non-tag
I believe that will fix it while also not-breaking everything else.
> github actions very confused about tags?
> ----------------------------------------
>
> Key: YETUS-966
> URL: https://issues.apache.org/jira/browse/YETUS-966
> Project: Yetus
> Issue Type: Improvement
> Components: Precommit
> Affects Versions: 0.12.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Critical
>
> The github action build for the rel/0.12.0 tag got very, very, very confused.
> See below for more.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
