[ 
https://issues.apache.org/jira/browse/YETUS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer resolved YETUS-305.
------------------------------------
    Resolution: Won't Fix

Closing as Won't Fix given that the current code base fetches old site tgzs and 
unpacks them rather than rebuild based upon a git clone.

> site building should check for minimum git version
> --------------------------------------------------
>
>                 Key: YETUS-305
>                 URL: https://issues.apache.org/jira/browse/YETUS-305
>             Project: Yetus
>          Issue Type: Improvement
>          Components: website and documentation
>    Affects Versions: 0.1.0, 0.2.0
>            Reporter: Sean Busbey
>            Priority: Minor
>              Labels: beginner
>
> When building per-release documentation, we do some git magic:
> {code}
>   puts "\tcloning from tag."
>   `(cd "#{output}" && git clone --depth 1 --branch "#{version}" 
> --single-branch -- "#{GITREPO}" "build-#{version}") 
> >"#{output}/#{version}_git_checkout.log" 2>&1`
>   unless $?.exitstatus == 0
>     abort("building docs failed to for #{version}.")
>   end
> {code}
> This doesn't work with older versions of git:
> {code}
> busbey2-MBA:asf-site-src busbey$ rvm use 2.2.0@yetus-site
> Using /Users/busbey/.rvm/gems/ruby-2.2.0 with gemset yetus-site
> gbusbey2-MBA:asf-site-src busbey$ git --version
> git version 1.7.10.2 (Apple Git-33)
> busbey2-MBA:asf-site-src busbey$ bundle exec middleman build
> Building docs for release 0.1.0
>       cleaning up output directories in ../target
>       cloning from tag.
> building docs failed to for 0.1.0.
> busbey2-MBA:asf-site-src busbey$ source ~/.bashrc
> busbey2-MBA:asf-site-src busbey$ git --version
> git version 2.1.0
> busbey2-MBA:asf-site-src busbey$ bundle exec middleman build
> Building docs for release 0.1.0
>       cleaning up output directories in ../target
>       cloning from tag.
>       setting up markdown docs
>       generating javadocs
>    identical  publish/assets/css/bootstrap-theme.css
>    identical  publish/assets/css/bootstrap-theme.min.css
>    identical  publish/assets/css/bootstrap.css
>    identical  publish/assets/css/bootstrap.min.css
>    identical  publish/assets/css/font-awesome.css
>    identical  publish/assets/css/font-awesome.min.css
>    identical  
> publish/documentation/in-progress/audience-annotations-apidocs/stylesheet.css
>    identical  publish/documentation/0.1.0/audience-annotation
>    ....SNIP....
> {code}
> we should check the git version and bail early.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to