[ 
https://issues.apache.org/jira/browse/YETUS-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209246#comment-17209246
 ] 

Roman Shaposhnik commented on YETUS-1017:
-----------------------------------------

+1 from me (with a caveat that I don't really have deep familiarity with the 
codebase) the changes look structurally correct and very clean 
implementation-wise

> Rework post-processing comparison to de-duplicate code
> ------------------------------------------------------
>
>                 Key: YETUS-1017
>                 URL: https://issues.apache.org/jira/browse/YETUS-1017
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Precommit
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.13.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Originally it was thought that many, many components would be MODULE based.  
> That's turning out not to be the case.  So a lot of the useful routines 
> labeled 'generic' are stuck behind the MODULE system.  It would be better to 
> specifically rename 'generic' stuff to be 'module' and make new 'generic' 
> routines that assume the root of the tree.  Making this change will greatly 
> improve the ability to quick add new static linters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to