[
https://issues.apache.org/jira/browse/YETUS-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated YETUS-1222:
------------------------------------
Description: There is an unprotected EXTRA_ARGS in smart-apply-patch that
newer versions of shellcheck (correctly) mark as SC2086. Given that it appears
to be undocumented and how passing --gpg-sign will break any external input,
let's change it to correctly be an array. It is still not recommended to
depend on this variable, however. (was: There is an unprotected EXTRA_ARGS in
smart-apply-patch that newer versions of shellcheck (correctly) mark as SC2086.
Given that it appears to be undocumented and how passing --gpg-sign will
break any external input, let's change it to correctly be an array.)
> smart-apply-patch EXTRA_ARGS should be an array
> -----------------------------------------------
>
> Key: YETUS-1222
> URL: https://issues.apache.org/jira/browse/YETUS-1222
> Project: Yetus
> Issue Type: Bug
> Components: Precommit
> Affects Versions: 0.14.1
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Major
>
> There is an unprotected EXTRA_ARGS in smart-apply-patch that newer versions
> of shellcheck (correctly) mark as SC2086. Given that it appears to be
> undocumented and how passing --gpg-sign will break any external input, let's
> change it to correctly be an array. It is still not recommended to depend on
> this variable, however.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
