eolivelli commented on a change in pull request #959: ZOOKEEPER-3402: Add multiRead operation URL: https://github.com/apache/zookeeper/pull/959#discussion_r289463802
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ########## @@ -1895,23 +1897,33 @@ private Op withRootPrefix(Op op) { protected void multiInternal(MultiTransactionRecord request, MultiCallback cb, Object ctx) { RequestHeader h = new RequestHeader(); - h.setType(ZooDefs.OpCode.multi); + switch (request.getOpKind()) { + case TRANSACTION: h.setType(ZooDefs.OpCode.multi); break; + case READ: h.setType(ZooDefs.OpCode.multiRead); break; Review comment: Nit: add default ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services