jhuan31 commented on a change in pull request #986: ZOOKEEPER-3243: Add
server-side request throttling
URL: https://github.com/apache/zookeeper/pull/986#discussion_r299166382
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java
##########
@@ -82,6 +80,22 @@ public ServerCnxn(final ZooKeeperServer zkServer) {
this.zkServer = zkServer;
}
+ /**
+ * Flag that indicates that this connection is known to be closed/closing
+ * and from which we can optionally ignore outstanding requests as part
+ * of request throttling. This flag may be false when a connection is
+ * actually closed (false negative), but should never be true with
+ * a connection is still alive (false positive).
Review comment:
Thanks for sharing your finding. It seems working for us so far. Will keep
an eye one it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
