jhuan31 commented on a change in pull request #995: ZOOKEEPER-3437: Improve
sync throttling on a learner master
URL: https://github.com/apache/zookeeper/pull/995#discussion_r300751692
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##########
@@ -968,6 +984,7 @@ protected long queueCommittedProposals(Iterator<Proposal>
itr,
public void shutdown() {
// Send the packet of death
try {
+ queuedPackets.clear();
Review comment:
Good catch! It is actually added in this patch to handle diff sync
throttling. Diff txns are queued in syncFollower() before the throttle. Later
when we decide that this diff sync should be throttled, the txns are in the
queues already so we need to remove them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
