lvfangmin commented on a change in pull request #1007: ZOOKEEPER-3448:
Introduce MessageTracker to assist debug leader and leaner connectivity issues.
URL: https://github.com/apache/zookeeper/pull/1007#discussion_r305986483
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java
##########
@@ -271,6 +280,8 @@ protected void setBufferedOutput(BufferedOutputStream
bufferedOutput) {
}
throw new SaslException("Authentication failure: " +
e.getMessage());
}
+
+ this.messageTracker = new MessageTracker(BUFFERED_MESSAGE_SIZE);
Review comment:
@hanm can you provide an option and disable this by default, I'm worried
about the performance impact by tracking this, and probably we only enable this
when we found there is potential consistency issue we want to debug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
