TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable 
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r312864700
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
 ##########
 @@ -928,12 +925,12 @@ else if (serverPath.length() > chrootPath.length())
                     packet.replyHeader.setErr(
                             KeeperException.Code.CONNECTIONLOSS.intValue());
                     throw new IOException("Xid out of order. Got Xid "
-                            + replyHdr.getXid() + " with err " +
-                            + replyHdr.getErr() +
-                            " expected Xid "
+                            + replyHdr.getXid() + " with err "
+                            + +replyHdr.getErr()
 
 Review comment:
   Here is a rule `+' should be on a new line`. For cleanup I guess you mean 
replace it with `String.format`? It would be a follow up to unify the 
log/Exception format and generation like that for javadoc(ZOOKEEPER-3469). This 
pull request would be a clean start point for all of this request but we should 
prevent it from too complex IMHO.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to