TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable 
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r312868387
 
 

 ##########
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/EphemeralType.java
 ##########
 @@ -188,24 +179,27 @@ public static EphemeralType get(long ephemeralOwner) {
     }
 
     /**
-     * Make sure the given server ID is compatible with the current extended 
ephemeral setting
+     * Make sure the given server ID is compatible with the current extended 
ephemeral setting.
      *
      * @param serverId Server ID
      * @throws RuntimeException extendedTypesEnabled is true but Server ID is 
too large
      */
     public static void validateServerId(long serverId) {
-        // TODO: in the future, serverId should be validated for all cases, 
not just the extendedEphemeralTypesEnabled case
+        // TODO: in the future, serverId should be validated for all cases,
 
 Review comment:
   Support. This is also how akka community tracked TODOs and it was a good 
practice yet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to