TisonKun edited a comment on issue #1049: ZOOKEEPER-3475 Enable Checkstyle 
configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#issuecomment-520605920
 
 
   @hanm 
   
   >There are lots of changes to exception types thrown by functions, where it 
changes concrete exception types that's a function could actually throw to 
Exception (see some detailed examples in comments). What's the reason behind 
this change?
   
   Those changes are made limited on test* methods where otherwise a long line 
to be breakdown. A test* method should be always ok to be written thrown 
`Exception` because any verification is done in the method and no one should 
rely on a test* method. It itself is a top level method.
   
   
   I support your advice that
   
   > Pure formatting changes: white spaces, curly braces, indentations, etc.
   > None functional changes: remove unneeded imports, unused exceptions types, 
unneeded type parameters, etc.
   
   Let me see what I can do to rebase this pull request. Formerly I give every 
file an auto formatting phase, a glance phase and a fixing error phase. Maybe 
the middle phase is problematic. I should have do it by only a fixing error 
phase.
   
   By the way, following this suggestion we could suppress *NameCheck in this 
pass and give a dedicated pass to revisit it. That is, checkstyle rules 
restrict the pattern of method names, field names and variable names.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to