anmolnar commented on a change in pull request #1048: ZOOKEEPER-3188: Improve resilience to network URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313420204
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java ########## @@ -18,16 +18,8 @@ package org.apache.zookeeper.server.admin; -import java.util.Arrays; -import java.util.Collections; -import java.util.HashMap; -import java.util.HashSet; -import java.util.List; -import java.util.Map; -import java.util.Properties; -import java.util.Set; -import java.util.SortedMap; -import java.util.TreeMap; +import java.net.InetSocketAddress; +import java.util.*; Review comment: Please avoid using asterisk imports. This a common coding practice across ZooKeeper. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services