symat commented on a change in pull request #1048: ZOOKEEPER-3188: Improve 
resilience to network
URL: https://github.com/apache/zookeeper/pull/1048#discussion_r313738065
 
 

 ##########
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java
 ##########
 @@ -657,11 +647,31 @@ public CommandResponse run(ZooKeeperServer zkServer, 
Map<String, String> kwargs)
                                 TreeMap::new));
             }
 
+            private String getMultiAddressString(QuorumPeer.QuorumServer qs) {
+                return qs.addr.getAllAddresses().stream()
+                        .map(address -> getSingleAddressString(qs, address))
+                        .collect(Collectors.joining(","));
+            }
+
+            private String getSingleAddressString(QuorumPeer.QuorumServer qs, 
InetSocketAddress address) {
 
 Review comment:
   Yes, I agree, I will change it. 
   
   This admin command is about to show the internal view of the voting members 
(how the zookeeper server thinks who the voting members are and where do they 
listen). I wouldn't complicate this PR any further, but it might be a good idea 
to create a follow-up ticket to have some admin command showing that if the 
given server can reach all the different ports of the other servers (not only 
the voting members). It can help debugging network problems, showing if certain 
network interfaces on some servers are unreachable. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to