ztzg opened a new pull request #1055: ZOOKEEPER-3510: Make 'zkServer.sh stop' 
more reliable
URL: https://github.com/apache/zookeeper/pull/1055
   As mentioned in 
https://github.com/apache/zookeeper/pull/1054#discussion_r314208678 :
   There is a `sleep 3` statement in `zkServer.sh restart`. I am unable to 
unearth the history of that particular line, but I believe part—if not all—of 
that sleep should be part of `zkServer.sh stop`.
   I frequently observe `FAILED TO START` errors in the C test suite; the logs 
consistently show that those are caused by `java.net.BindException: Address 
already in use`. Adding a simple `sleep 1` before `echo STOPPED` "fixes" it for 
   As noted in the commit message, the `sleep` is far from optimal, an adaptive 
mechanism would be better—but I do not want to make the first iteration too 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to