eolivelli commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314188638
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java ########## @@ -131,12 +128,7 @@ private Bootstrap configureBootstrapAllocator(Bootstrap bootstrap) { void connect(InetSocketAddress addr) throws IOException { firstConnect = new CountDownLatch(1); - Bootstrap bootstrap = new Bootstrap() - .group(eventLoopGroup) - .channel(NettyUtils.nioOrEpollSocketChannel()) - .option(ChannelOption.SO_LINGER, -1) - .option(ChannelOption.TCP_NODELAY, true) - .handler(new ZKClientPipelineFactory(addr.getHostString(), addr.getPort())); + Bootstrap bootstrap = new Bootstrap().group(eventLoopGroup).channel(NettyUtils.nioOrEpollSocketChannel()).option(ChannelOption.SO_LINGER, -1).option(ChannelOption.TCP_NODELAY, true).handler(new ZKClientPipelineFactory(addr.getHostString(), addr.getPort())); Review comment: this line was more readable before ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services