TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable 
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314405124
 
 

 ##########
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/client/ZooKeeperSaslClient.java
 ##########
 @@ -442,11 +428,9 @@ public boolean clientTunneledAuthenticationInProgress() {
                 }
 
                 // 2. SASL authentication has succeeded or failed..
-                if (!gotLastPacket) {
-                    // ..but still in progress, because there is a final SASL
-                    // message from server which must be received.
-                    return true;
-                }
+                // ..but still in progress, because there is a final SASL
+                // message from server which must be received.
+                return !gotLastPacket;
 
 Review comment:
   Reverting...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to