TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable 
Checkstyle configuration on zookeeper-server
URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314554375
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
 ##########
 @@ -433,22 +417,22 @@ public WatcherSetEventPair(Set<Watcher> watchers, 
WatchedEvent event) {
      */
     private static String makeThreadName(String suffix) {
         String name = Thread.currentThread().getName().
-            replaceAll("-EventThread", "");
+                                                              
replaceAll("-EventThread", "");
 
 Review comment:
   There is no checkstyle rule guard this and I accidentally introduce it when 
auto-formatting...
   
   I will check these changes for now and try to find a rule to forbid this 
pattern. However, given how to break lines is nearly arbitrary by the meaning 
of the codes, it is hard to express such a rule.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to