TisonKun commented on a change in pull request #1049: ZOOKEEPER-3475 Enable Checkstyle configuration on zookeeper-server URL: https://github.com/apache/zookeeper/pull/1049#discussion_r314580886
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooDefs.java ########## @@ -109,45 +111,43 @@ int ADMIN = 1 << 4; int ALL = READ | WRITE | CREATE | DELETE | ADMIN; + } @InterfaceAudience.Public public interface Ids { + /** * This Id represents anyone. */ - public final Id ANYONE_ID_UNSAFE = new Id("world", "anyone"); + Id ANYONE_ID_UNSAFE = new Id("world", "anyone"); Review comment: Any field in an interface must be `public static final`. There is a rule `redundant modifier` check this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services