sonymoon commented on a change in pull request #1034: ZOOKEEPER-3491 Specify
commitLogCount value using a system property
URL: https://github.com/apache/zookeeper/pull/1034#discussion_r321580644
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java
##########
@@ -120,6 +124,23 @@ public ZKDatabase(FileTxnSnapLog snapLog) {
snapshotSizeFactor = DEFAULT_SNAPSHOT_SIZE_FACTOR;
}
LOG.info("{} = {}", SNAPSHOT_SIZE_FACTOR, snapshotSizeFactor);
+
+ try {
+ commitLogCount = Integer.parseInt(
+ System.getProperty(COMMIT_LOG_COUNT,
+ Integer.toString(DEFAULT_COMMIT_LOG_COUNT)));
+ if (commitLogCount < DEFAULT_COMMIT_LOG_COUNT) {
+ commitLogCount = DEFAULT_COMMIT_LOG_COUNT;
+ LOG.warn("The configured {} is less than the recommended {}" +
Review comment:
Hi, hanm
I prefer 'The configured `commitLogCount` {} ...', this makes warning log
more readable. Anyway, your call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
