TisonKun commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329841547
########## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ########## @@ -1273,11 +1279,13 @@ public ZooKeeper( boolean canBeReadOnly, HostProvider aHostProvider, ZKClientConfig clientConfig) throws IOException { - LOG.info("Initiating client connection, connectString=" + connectString - + " sessionTimeout=" + sessionTimeout - + " watcher=" + watcher - + " sessionId=" + Long.toHexString(sessionId) - + " sessionPasswd=" + (sessionPasswd == null ? "<null>" : "<hidden>")); + LOG.info( + "Initiating client connection, connectString={} sessionTimeout={} watcher={} sessionId={} sessionPasswd={}", Review comment: Updated ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services