arshadmohammad commented on issue #1101: ZOOKEEPER-3561: Generalize target authentication scheme for ZooKeeper authentication enforcement URL: https://github.com/apache/zookeeper/pull/1101#issuecomment-538074820 @hanm I did my changes on top of ZOOKEEPER-1634. Almost done, one c test case is failing i will handle it but before there is concern i wanted to discuss. 1. cnxn.sendCloseSession(); does not really close the session. It is just sending false notification that session closed. So I think we should call close(cnxn.getSessionId()); to really close the session. 2. Attempting zk operation without authentication is serious act, I think we should not only close the session and also close the connection. But when session and connection are closed client only get connection loss exception it can not get the exception we wanted to throw in authentication check fail scenario. What your thought shall we do 1. and 2.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
