enixon commented on a change in pull request #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#discussion_r334261022
########## File path: zookeeper-client/zookeeper-client-c/src/zookeeper.c ########## @@ -1037,13 +1071,13 @@ int update_addrs(zhandle_t *zh) zh->state = ZOO_NOTCONNECTED_STATE; } -fail: +done: Review comment: naming nit - "done" is technically accurate but doesn't capture the sense of an early finish. Alternatives? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services