Randgalt commented on issue #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#issuecomment-544836783 > One more thing on the testing side. > > Currently we run the same unit tests for all impl of WatchManagers in `WatchManagerTest`. If we end up not implementing persistent watcher for the optimized version, I think we will need to break these tests and separately test persistent/recursive watchers in the tests of standard WatchManager. @anmolnar The Watch Manager tests that test both implementations haven't changed. I created separate tests for Persistent watches. So, this all works as expected. Per @eolivelli I've just added a specific test for "custom" watch managers that don't implement the new addWatch.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
