eolivelli commented on a change in pull request #1106: ZOOKEEPER-1416 - 
Persistent, recursive watchers
URL: https://github.com/apache/zookeeper/pull/1106#discussion_r341853498
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java
 ##########
 @@ -373,6 +405,18 @@ void containsWatcher(String path, Watcher watcher, 
WatcherType watcherType) thro
                 synchronized (childWatches) {
                     containsWatcher = contains(path, watcher, childWatches);
                 }
+
+                synchronized (persistentWatches) {
+                    boolean contains_temp = contains(path, watcher,
+                            persistentWatches);
 
 Review comment:
   In my opinion we should move forward with this patch.
   I appreciate @maoling comments but this patch is very big and we should 
focus on the core of the change.
   Any tech debt we got from the past can be addressed in separate patches.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to