Randgalt commented on issue #1132: ZOOKEEPER-3605 - connThrottle needs to be 
assigned in alternate consructor
URL: https://github.com/apache/zookeeper/pull/1132#issuecomment-550300292
 
 
   @anmolnar 
   
   - I moved the assignment to the field declaration
   - "We only use the default constructor in tests. Is it valid that's part of 
the public API?" - Curator uses it for its Testing module (which is used more 
than Curator itself). So, it's part of the public API for testing anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to